From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 16 Jan 2009 20:58:46 GMT
Subject: Re: [PATCH 1/2] Move run_hook() from builtin-commit.c into run-command.c (libgit)
Message-ID: <alpine.DEB.1.00.0901162157400.3586@pacific.mpi-cbg.de>
In-Reply-To: <20090116172521.GD28177@leksak.fem-net>

Hi,

On Fri, 16 Jan 2009, Stephan Beyer wrote:

> Dscho wrote:
>
> > Lots of improvements possible (I agree; _after_ this patch):
> [...]
> 
> > - use an strbuf for the index file
> 
> Is that useful in some way?
> Currently it would only adds code to generate strbufs at the caller
> side. And in the case the caller has a strbuf for the index file, it
> can simply use the .buf member.

Of course I meant the buffer into which "GIT_INDEX_FILE=..." is written, 
which is fixed size ATM.

Ciao,
Dscho