From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 14 Jan 2009 15:44:36 GMT
Subject: Re: [PATCH 3/3] implement pattern matching in ce_path_match
Message-ID: <alpine.DEB.1.00.0901141641500.3586@pacific.mpi-cbg.de>
In-Reply-To: <1231944876-29930-4-git-send-email-drizzd@aon.at>

Hi,

On Wed, 14 Jan 2009, Clemens Buchacher wrote:

> @@ -25,6 +25,17 @@ static int default_show_root = 1;
>  static const char *fmt_patch_subject_prefix = "PATCH";
>  static const char *fmt_pretty;
>  
> +static int has_special(const char *p)
> +{
> +	int x;
> +
> +	while ((x = *p++) != '\0')
> +		if (isspecial(x))
> +			return 1;
> +
> +	return 0;
> +}

I would prefer something like this:

	static int has_special(const char *p)
	{
		while (*p)
			if (isspecial(*(p++)))
				return 1;
		return 0;
	}

but that is probably a matter of taste.

Ciao,
Dscho