From: Johannes Schindelin Date: Fri, 02 Jan 2009 21:59:43 GMT Subject: Re: [PATCH 2/3] unpack-trees: fix path search bug in verify_absent Message-ID: In-Reply-To: <1230843273-11056-3-git-send-email-drizzd@aon.at> On Thu, 1 Jan 2009, Clemens Buchacher wrote: > Commit 0cf73755 (unpack-trees.c: assume submodules are clean during > check-out) changed an argument to verify_absent from 'path' to 'ce', > which is however shadowed by a local variable of the same name. > > The bug triggers if verify_absent is used on a tree entry, for which > the index contains one or more subsequent directories of the same > length. The affected subdirectories are removed from the index. The > testcase included in this commit bisects to 55218834 (checkout: do not > lose staged removal), which reveals the bug in this case, but is > otherwise unrelated. > --- Sign-off? Just for the record, this patch fixes the testcase Miklos reported earlier. Ciao, Dscho