From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 27 Jul 2008 20:21:04 GMT
Subject: Re: [PATCH 2/7] builtin-help: change the current directory back in list_commands_in_dir()
Message-ID: <alpine.DEB.1.00.0807272219350.5526@eeepc-johanness>
In-Reply-To: <7vwsj7yu1q.fsf@gitster.siamese.dyndns.org>

Hi,

On Sun, 27 Jul 2008, Junio C Hamano wrote:

> Miklos Vajna <vmiklos@frugalware.org> writes:
> 
> > That function used to do a chdir() without switching back to the 
> > original directory. That was not a problem till this function was used 
> > only inside builtin-help, but once other builtins use it as well, this 
> > is a problem, for example when the object database path is relative.
> 
> Why does it even need to chdir() around to begin with?  Doesn't 
> opendir() work just fine with relative path as an input?

It is a consequence of list_commands_in_dir() trying to be cute, and not 
having to construct the full path for the is_executable() check.

Will post a fix in a few minutes.

Ciao,
Dscho