From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 26 Jul 2008 17:42:36 GMT
Subject: Re: [PATCH] Set up argv0_path correctly, even when argv[0] is just the basename
Message-ID: <alpine.DEB.1.00.0807261940450.26810@eeepc-johanness>
In-Reply-To: <7vod4kft7d.fsf@gitster.siamese.dyndns.org>

Hi,

On Sat, 26 Jul 2008, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > However, argv0_path needs the full path, so add a function to discover 
> > the program by traversing the PATH manually.
> 
> I think unconditionally requiring argv0_path to be set is the root cause 
> of the bug.  Unless we do not fix _that_, we will have to make a 
> needless call to lookup_program_in_path() even when nobody needs that 
> information, which is unacceptable.

Fair enough.  How about having a function called from system_path() which 
has a flag so it is run only once, and then calls lookup_program_in_path() 
provided that argv0_path contains no slashes _and_ exec_path is relative?

Ciao,
Dscho