From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 26 Jul 2008 00:55:17 GMT
Subject: Re: [PATCH 6/9] builtin-init-db.c: use parse_options()
Message-ID: <alpine.DEB.1.00.0807260254010.11976@eeepc-johanness>
In-Reply-To: <4889EF3A.6040605@free.fr>

Hi,

On Fri, 25 Jul 2008, Olivier Marin wrote:

> Johannes Schindelin a écrit :
> 
> > We rely on shared_repository == 0 for non-shared repositories _almost 
> > everywhere_.
> 
> I think we rely on the fact that PERM_UMASK == 0 and not on the value of 
> shared_repository. Not the same thing.

Just look at all the cases where we ask for "if (shared_repository)".  
And then look where PERM_UMASK is assigned to.  It _is_ the same thing.

Hth,
Dscho