From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 22 Jul 2008 21:32:03 GMT
Subject: Re: [PATCH/RFC] git add: do not add files from a submodule
Message-ID: <alpine.DEB.1.00.0807222230490.8986@racer>
In-Reply-To: <alpine.DEB.1.00.0807210256510.3305@eeepc-johanness>

Hi Junio,

On Mon, 21 Jul 2008, Johannes Schindelin wrote:

> It comes quite as a surprise to an unsuspecting Git user that calling
> "git add submodule/file" (which is a mistake, alright) _removes_
> the submodule in the index, and adds the file.  Instead, complain loudly.
> 
> While at it, be nice when the user said "git add submodule/" which is
> most likely the consequence of tab-completion, and stage the submodule,
> instead of trying to add the contents of that directory.

Do you plan to apply the split-up builtin-add enhancments you did a few 
nights ago, so that this patch can be elegant?  I think this fix should go 
into 1.6.0.

Ciao,
Dscho