From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 16 Jul 2008 22:41:57 GMT
Subject: Re: [PATCH 6/7] git rm: Support for removing submodules
Message-ID: <alpine.DEB.1.00.0807170038430.4318@eeepc-johanness>
In-Reply-To: <20080716191134.19772.85003.stgit@localhost>

Hi,

On Wed, 16 Jul 2008, Petr Baudis wrote:

> This patch adds support for removing submodules to 'git rm', including 
> removing the appropriate sections from the .gitmodules file to reflect 
> this

I have no time to look at the whole series, or even at the patch, but I 
have concerns.  Do you really remove the whole directory?  Because if you 
do, you remove more than what can be possibly reconstructed from the 
object store.

That is much more dangerous than what "git rm" does.

For example, you can have local branches, remote settings, untracked 
files, etc. in the subdirectory.  And that cannot be recovered once 
deleted.

I wonder if it really makes sense to integrate that into git-rm, and not 
git-submodule, if only to introduce another level of consideration for the 
user before committing what is potentially a big mistake.

Ciao,
Dscho