From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 08 Jul 2008 10:59:43 GMT
Subject: Re: [PATCH 1/6] revisions: refactor init_revisions and setup_revisions.
Message-ID: <alpine.DEB.1.00.0807081258010.4319@eeepc-johanness>
In-Reply-To: <1215510964-16664-2-git-send-email-madcoder@debian.org>

Hi,

On Tue, 8 Jul 2008, Pierre Habouzit wrote:

> setup_revisions has been split in two: parse_revisions that does 
> (almost) only argument parsing, to be more like what parse-options can 
> do, and setup_revisions that does the rest.

I do not see the sense of this change, except

- blowing up your patch unnecessarily,
- making it more inconvenient for users, and
- adding an opportunity for bugs to creep in.

In other words, I would like to see the semantics of setup_revisions() 
untouched.

Ciao,
Dscho