From: Johannes Schindelin Date: Mon, 23 Jun 2008 18:41:10 GMT Subject: Re: [RFC] Re: Convert 'git blame' to parse_options() Message-ID: In-Reply-To: <20080623172612.GD27265@sigill.intra.peff.net> Hi, On Mon, 23 Jun 2008, Jeff King wrote: > On Mon, Jun 23, 2008 at 06:04:48PM +0100, Johannes Schindelin wrote: > > > > > Thinking about the recursive approach again, I came up with this > > > > POC: > > > > > > "recursive" is pointless. > > > > Nope, it is not. > > AIUI, one difference between your approach and Pierre's is that he is > suggesting (and I have suggested this in the past, too) a big > DIFF_OPTIONS macro that you stick in the options table for each command. > Whereas you are allowing for subtables accessible via pointers. > > Your approach should yield a much leaner text size Yes, this is the only difference between Pierre's current approach and my POC. > > Heck, we could just as easily introduce PARSE_OPT_IGNORE_UNKNOWN. > > We could even send it to the list with message-id > > http://mid.gmane.org/1213758236-979-2-git-send-email-shawn.bohrer@gmail.com > > and then Junio and I could complain that the concept is broken. Heh. I thought I saw it, but a quick search did not reveal it, and I really don't have time to work on this, unfortunately. Thanks, Dscho