From: Johannes Schindelin Date: Wed, 11 Jun 2008 21:44:17 GMT Subject: Re: [PATCH 2/2] git-gc: skip stashes when expiring reflogs Message-ID: In-Reply-To: <20080611213648.GA13362@glandium.org> Hi, On Wed, 11 Jun 2008, Mike Hommey wrote: > On Wed, Jun 11, 2008 at 04:29:56PM -0500, Brandon Casey wrote: > > The stash makes use of git's reflog mechanism, but it is not a reflog > > in the traditional sense. Each entry is a state that the user > > explicitly requested git to remember. The stash is generally > > short-lived, but the user probably expects that a stash will continue > > to exist until it is explicitly deleted. So we should not expire stash > > entries. > > I wonder if it wouldn't make sense to have git reflog expire not expire > stashes *at all*. I mean, you don't necessarily cleanup your repo with > git gc, and you may end up killing your stashes with git reflog yourself > if you don't use the "magic" --exclude... FWIW I thought it was one of the clever designs of git-stash that it automatically expires together with the other reflogs. A stash is only a temporary thing, that is not even meant to leave the local repository, after all. Ciao, Dscho