From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 09 Jun 2008 01:02:14 GMT
Subject: Re: [PATCH] cat-file --batch / --batch-check: do not exit if hashes are missing
Message-ID: <alpine.DEB.1.00.0806090201090.1783@racer>
In-Reply-To: <484C73DA.10804@gmail.com>

Hi,

On Mon, 9 Jun 2008, Lea Wiemann wrote:

> Johannes Schindelin wrote:
> > Lea Wiemann wrote:
> > > -	if (type <= 0)
> > > -		return 1;
> > > +	if (type <= 0) {
> > > +		printf("%s missing\n", obj_name);
> > > +		fflush(stdout);
> > > +		return 0;
> > > +	}
> > 
> > Is it really intended that it returns 0 now?
> 
> Yes, return 0 causes it to not exit (which is the desired effect, as in
> documented).

That is unexpected.  IMO this is a bug.  rev-parse I can understand, but 
cat-file not failing when it clearly did not find the object?

Ciao,
Dscho