From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 08 Jun 2008 15:07:23 GMT
Subject: Re: [TOY PATCH] git wrapper: show similar command names for an unknown command
Message-ID: <alpine.DEB.1.00.0806081607040.1783@racer>
In-Reply-To: <7vmylxnmnz.fsf@gitster.siamese.dyndns.org>

Hi,

On Sat, 7 Jun 2008, Junio C Hamano wrote:

> Alex Riesen <raa.lkml@gmail.com> writes:
> 
> > Johannes Schindelin, Sat, Jun 07, 2008 17:04:14 +0200:
> >> -	for (i = 0; i < main_cmds.cnt; i++) {
> >> +	for (i = 0; i < main_cmds.cnt && i < 5; i++) {
> >
> > I accidentally considered "i" just the index in the global command
> > table. Of course it is better :)
> 
> That confusion however shows how hacky the approach to clobber the 
> main_cmds global table by stuffing other things in it and sorting, 
> without saying "who cares, we will exit after we are done with this 
> processing anyway".  If this patch were for inclusion, such a comment 
> should be there immediately before it starts to muck with the command 
> table.

This patch is not meant for inclusion, as indicated by the "TOY PATCH" 
prefix.

Ciao,
Dscho