From: Johannes Schindelin Date: Mon, 02 Jun 2008 22:15:45 GMT Subject: Re: [JGIT PATCH 00/12] Extensions in core needed by PackWriter Message-ID: In-Reply-To: <1212441883-12990-1-git-send-email-marek.zawirski@gmail.com> Hi, On Mon, 2 Jun 2008, Marek Zawirski wrote: > Series start with formatting stuff, as some old files were not > appropriatelly formatted. You mean line-wrapping, right? Is there a different recommended column/line ratio for JGit than for Git? Because some of your later patches introduce lines longer than 80 columns/line. > Add getType() method to RevObject hierarchy Was the idea not to use instanceof to be able to have multiple "types" per object? I.e. a commit object is of type commit, but also of type object... BTW I really like the iterator implementation. Ciao, Dscho