From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 29 May 2008 12:43:57 GMT
Subject: Re: [PATCH] make commit --interactive lock index
Message-ID: <alpine.DEB.1.00.0805291343120.13507@racer.site.net>
In-Reply-To: <E1K1eXH-00063c-Bt@fencepost.gnu.org>

Hi,

On Thu, 29 May 2008, Paolo Bonzini wrote:

> @@ -233,6 +228,8 @@ static char *prepare_index(int argc, const char **argv, const char *prefix)
>  	if (*argv)
>  		pathspec = get_pathspec(prefix, argv);
>  
> +	assert (!(interactive && pathspec && *pathspec));

As pathspec is specified indirectly by the user, I think an assert() here 
is actively wrong.

Ciao,
Dscho