From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 26 May 2008 10:05:51 GMT
Subject: Re: [PATCH] log --pretty: do not accept bogus "--prettyshort"
Message-ID: <alpine.DEB.1.00.0805261105090.30431@racer>
In-Reply-To: <7vy75xeoql.fsf@gitster.siamese.dyndns.org>

Hi,

On Sun, 25 May 2008, Junio C Hamano wrote:

> diff --git a/revision.c b/revision.c
> index ac057e1..fc66755 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -1197,11 +1197,16 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
>  				revs->verbose_header = 1;
>  				continue;
>  			}
> -			if (!prefixcmp(arg, "--pretty")) {
> +			if (!strcmp(arg, "--pretty")) {
>  				revs->verbose_header = 1;
>  				get_commit_format(arg+8, revs);

Does "args+8" really make sense, still?  Okay, it is the same as "", but 
the latter would not make me go "Hum?!".

Ciao,
Dscho