From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 12 May 2008 17:04:42 GMT
Subject: Re: [PATCH 2/5] Make mktag a builtin.
Message-ID: <alpine.DEB.1.00.0805121803320.30431@racer>
In-Reply-To: <48285DAB.2040707@nrlssc.navy.mil>

Hi,

On Mon, 12 May 2008, Brandon Casey wrote:

> Junio C Hamano wrote:
> > drafnel@gmail.com writes:
> > 
> >> From: Brandon Casey <drafnel@gmail.com>
> >>
> >> Signed-off-by: Brandon Casey <drafnel@gmail.com>
> > 
> >> @@ -306,6 +305,7 @@ BUILT_INS += git-fsck-objects$X
> >>  BUILT_INS += git-get-tar-commit-id$X
> >>  BUILT_INS += git-init$X
> >>  BUILT_INS += git-merge-subtree$X
> >> +BUILT_INS += git-mktag$X
> >>  BUILT_INS += git-peek-remote$X
> >>  BUILT_INS += git-repo-config$X
> >>  BUILT_INS += git-show$X
> >> @@ -423,6 +423,7 @@ LIB_OBJS += log-tree.o
> >>  LIB_OBJS += mailmap.o
> >>  LIB_OBJS += match-trees.o
> >>  LIB_OBJS += merge-file.o
> >> +LIB_OBJS += mktag.o
> > 
> > This is unusual for a builtin.  Why didn't it migrate to builtin-mktag?
> 
> I didn't know how to do it.
> 
> I was trying not to do a code move and a code change at the same time.

Why did you not consult Git's own history for guidance?  See e.g.

	$ git log next --diff-filter=A builtin-*.c

Ciao,
Dscho