From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 05 May 2008 13:39:46 GMT
Subject: Re: [PATCH] Pay attention to GIT_DIR when searching the git directory
Message-ID: <alpine.DEB.1.00.0805051437040.30431@racer>
In-Reply-To: <20080505125302.GA11523@alea.gnuu.de>

Hi,

On Mon, 5 May 2008, Jörg Sommer wrote:

> Johannes Schindelin schrieb am Mon 05. May, 12:36 (+0100):
>
> > Please keep in mind that the commit log is meant to demonstrate the 
> > _intention_ of the patches.
> 
> The intention is that the variable GIT_DIR is respected when searching 
> for the git dir.

AFAICT the core of git respects GIT_DIR very much.  Reading your oneline, 
indeed, the whole commit message, scared me a bit, because I thought that 
there was a bug in core git.

Your commit message completely misses out on the fact that it fixes a bug 
in a _hook_, and a _contributed_ at that.

So I would have known _exactly_ what you did if your oneline had read

	contrib/hooks/setgitperms: respect GIT_DIR

Don't you agree?

Ciao,
Dscho