From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 04 May 2008 09:54:19 GMT
Subject: Re: [PATCH v3 5/6] fn_out_diff_words_aux: Handle common diff line more carefully
Message-ID: <alpine.DEB.1.00.0805041053380.30431@racer>
In-Reply-To: <1209874815-14411-6-git-send-email-pkufranky@gmail.com>

Hi,

On Sun, 4 May 2008, Ping Yin wrote:

> Before feeding minus and plus lines into xdi_diff, we replace non word
> characters with '\n'. So we need recover the replaced character (always
> the last character) in the callback fn_out_diff_words_aux.
> 
> Therefore, a common diff line beginning with ' ' is not always a real
> common line.

Umm, why?

> And we should check the last characters of the common diff line. If they 
> are different, we should output the first len-1 characters as the common 
> part and then the last characters in minus and plus separately.

Umm, why?

Ciao,
Dscho