From: Johannes Schindelin Date: Mon, 28 Apr 2008 18:37:54 GMT Subject: Re: [PATCH] git-daemon: fix for rotating logs Message-ID: In-Reply-To: <20080428182917.GA4794@glandium.org> Hi, On Mon, 28 Apr 2008, Mike Hommey wrote: > On Mon, Apr 28, 2008 at 08:21:14PM +0200, Miklos Vajna wrote: > > On Mon, Apr 28, 2008 at 07:08:50PM +0100, Johannes Schindelin wrote: > > > > > With rotating logs, there is a problem when the syslog is opened > > > > > only once (in the beginning). So open the log everytime we > > > > > write something, and close it directly after writing. > > > > > > > > Gaah, this is ugly. > > > > > > > > Is this something all the daemons need to deal with? > > > > > > I have no idea, but it seems to fix a real issue. > > > > logrotate supports sending a signal (typically SIGHUP) to the process > > after it rotated the log. Couldn't we just re-open the log on SIGHUP? > > Isn't the problem that git-daemon loses its connection to the syslog > daemon when logrotate sighups syslog? I have no idea, but other programs must have the same problem. I should have shown some diligence and researched that. Will do so now. Ciao, Dscho