From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 23 Apr 2008 20:14:16 GMT
Subject: Re: [PATCH 1/3] Add --blob-filter option to filter-branch.
Message-ID: <alpine.DEB.1.00.0804232113480.20267@eeepc-johanness>
In-Reply-To: <32541b130804231312n50e86ce6g2b2331ca514ba982@mail.gmail.com>

Hi,

On Wed, 23 Apr 2008, Avery Pennarun wrote:

> On 4/23/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > Not all of this belongs in the commit messaage.
> >
> >  > Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > This does.
> >
> >  A good general rule is: if you think it would be funny/strange to 
> >  read this message in the output of "git log", it should be changed.
> 
> I felt uncomfortable modifying the message attached to Jeff's patch
> (which actually does pretty clearly explain what's going on), since
> it's not mine.  If he wants to send me a better commit message,
> that'll be fine too.

Well, I think that you would do a good job rephrasing this as a proper 
commit message :-)

Ciao,
Dscho