From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 06 Apr 2008 21:06:24 GMT
Subject: Re: [PATCH 1/4] Add history graph API
Message-ID: <alpine.DEB.1.00.0804062204580.12583@eeepc-johanness>
In-Reply-To: <1207507332-1866-1-git-send-email-adam@adamsimpkins.net>

Hi,

On Sun, 6 Apr 2008, Adam Simpkins wrote:

> diff --git a/graph.h b/graph.h
> new file mode 100644
> index 0000000..fc23bf2
> --- /dev/null
> +++ b/graph.h
> @@ -0,0 +1,57 @@
> +#ifndef GRAPH_H
> +#define GRAPH_H
> +
> +/* A graph is a pointer to this opaque structure */
> +struct git_graph;
> +
> +/* Defined in commit.h */
> +struct commit;
> +/* Defined in strbuf.h */
> +struct strbuf;

You do not need those.

Apart from that, it looks very, very clean to me.  (Except maybe the 
prefix ++ that could have been a postfix ++ in the line before, but that 
is just me.)

Ciao,
Dscho