From: Patrick Steinhardt Date: Wed, 15 Jul 2026 06:22:13 GMT Subject: Re: [PATCH v3 7/9] pack-bitmap: introduce function to open bitmap for a single source Message-ID: In-Reply-To: <875x2gn7rx.fsf@emacs.iotcl.com> On Wed, Jul 15, 2026 at 07:25:54AM +0200, Toon Claes wrote: > Patrick Steinhardt writes: > > > The function `prepare_bitmap_git()` opens the first bitmap it can find > > in any of the object sources connected to the repository. In a > > subsequent commit, the "packed" object database backend will learn to > > use bitmaps to answer object filters when enumerating objects. That > > backend operates on a single object source though, so using a bitmap > > that potentially belongs to a different source would be wrong: > > > > - The source would yield objects that are not part of the source > > itself. > > > > - The object source info would be attributed to the wrong source. > > > > - With multiple sources, each source would enumerate the same bitmap > > another time. > > > > Introduce a new function `prepare_source_bitmap_git()` that only opens > > bitmaps belonging to the given object source. > > Tinies nit: this should be `prepare_bitmap_git_for_source()` Indeed it should be, good catch. Shows that I've been iterating on the name a bit :) Patrick