From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 14 Jul 2026 07:39:33 GMT
Subject: Re: [PATCH 1/2] t1100: modernize test style
Message-ID: <alXntdc-FO-1IHSV@pks.im>
In-Reply-To: <20260713140142.27898-2-diy2903@gmail.com>

On Mon, Jul 13, 2026 at 07:31:40PM +0530, Shlok Kulshreshtha wrote:
> diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh
> index ae66ba5bab..fabe5a97cb 100755
> --- a/t/t1100-commit-tree-options.sh
> +++ b/t/t1100-commit-tree-options.sh
> @@ -22,28 +22,28 @@ committer Committer Name <committer@email> 1117150200 +0000
>  comment text
>  EOF
>  
> -test_expect_success \
> -    'test preparation: write empty tree' \
> -    'git write-tree >treeid'
> -
> -test_expect_success \
> -    'construct commit' \
> -    'echo comment text |
> -     GIT_AUTHOR_NAME="Author Name" \
> -     GIT_AUTHOR_EMAIL="author@email" \
> -     GIT_AUTHOR_DATE="2005-05-26 23:00" \
> -     GIT_COMMITTER_NAME="Committer Name" \
> -     GIT_COMMITTER_EMAIL="committer@email" \
> -     GIT_COMMITTER_DATE="2005-05-26 23:30" \
> -     TZ=GMT git commit-tree $(cat treeid) >commitid 2>/dev/null'
> -
> -test_expect_success \
> -    'read commit' \
> -    'git cat-file commit $(cat commitid) >commit'
> -
> -test_expect_success \
> -    'compare commit' \
> -    'test_cmp expected commit'
> +test_expect_success 'test preparation: write empty tree' '
> +	git write-tree >treeid
> +'
> +
> +test_expect_success 'construct commit' '
> +	echo comment text |
> +	GIT_AUTHOR_NAME="Author Name" \
> +	GIT_AUTHOR_EMAIL="author@email" \
> +	GIT_AUTHOR_DATE="2005-05-26 23:00" \
> +	GIT_COMMITTER_NAME="Committer Name" \
> +	GIT_COMMITTER_EMAIL="committer@email" \
> +	GIT_COMMITTER_DATE="2005-05-26 23:30" \
> +	TZ=GMT git commit-tree $(cat treeid) >commitid 2>/dev/null
> +'
> +
> +test_expect_success 'read commit' '
> +	git cat-file commit $(cat commitid) >commit
> +'
> +
> +test_expect_success 'compare commit' '
> +	test_cmp expected commit
> +'
>  
>  
>  test_expect_success 'flags and then non flags' '

Nit: let's remove the extraneous empty line while at it.

Patrick