From: Taylor Blau Date: Fri, 10 Jul 2026 22:41:23 GMT Subject: Re: [PATCH v2 5/8] pack-bitmap: drop `_1` suffix from functions that open bitmaps Message-ID: In-Reply-To: <20260710-pks-odb-for-each-object-filter-v2-5-3710a9cc165a@pks.im> On Fri, Jul 10, 2026 at 10:48:57AM +0200, Patrick Steinhardt wrote: > In the preceding commit we've refactored how we open bitmaps. As part of > the refactoring we have consolidated `open_pack_bitmap()` as well as > `open_midx_bitmap()` into `open_bitmap_for_source()`. Consequently, we > only have their `open_pack_bitmap_1()` and `open_midx_bitmap_1()` > variants left over, where the `_1` suffix doesn't really make much sense > anymore. > > Drop the suffix. Makes sense. Thanks for keeping this in a separate commit. Thanks, Taylor