From: Patrick Steinhardt Date: Fri, 10 Jul 2026 07:09:12 GMT Subject: Re: [PATCH 7/7] builtin/cat-file: filter objects via object database Message-ID: In-Reply-To: On Thu, Jul 09, 2026 at 11:59:29AM -0700, Junio C Hamano wrote: > Patrick Steinhardt writes: > > > Refactor git-cat-file(1) to use the new object filter option when > > batching all objects. This significantly simplifies the logic and > > ensures that we don't have to reach into internals of the "files" source > > anymore. > > This would become more convincing if you spent a few lines before > presenting the solution to give an observation of what the current > code does, e.g., > > When batching all objects, git-cat-file(1) reaches into the > internals of the object database and manually manages bitmaps to > apply object filters. This creates coupling between the command > and ODB backend internals. > > to highlight the perceived problem in it. That would flow naturally > to the description of your solution. Good point, will add. Patrick