From: Patrick Steinhardt <ps@pks.im>
Date: Fri, 03 Jul 2026 05:21:17 GMT
Subject: Re: [PATCH] meson: restore hook-list.h to builtin_sources
Message-ID: <akdGzbF7dex9XQwp@pks.im>
In-Reply-To: <CAJ0EP43gyQf_XhCLCNEzCq9wMYXZBQX=PWjR-wYqoESSvByJiA@mail.gmail.com>

On Thu, Jul 02, 2026 at 01:03:05PM -0400, Mike Gilbert wrote:
> On Thu, Jul 2, 2026 at 7:06 AM Patrick Steinhardt <ps@pks.im> wrote:
> > On Wed, Jul 01, 2026 at 03:39:28PM -0400, Mike Gilbert wrote:
> > > diff --git a/meson.build b/meson.build
> > > index 3247697f74aa..bdc83843e8e0 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -566,19 +579,8 @@ libgit_sources += custom_target(
> > >    env: script_environment,
> > >  )
> > >
> > > -libgit_sources += custom_target(
> > > -  input: 'Documentation/githooks.adoc',
> > > -  output: 'hook-list.h',
> > > -  command: [
> > > -    shell,
> > > -    meson.current_source_dir() + '/tools/generate-hooklist.sh',
> > > -    meson.current_source_dir(),
> > > -    '@OUTPUT@',
> > > -  ],
> > > -  env: script_environment,
> > > -)
> > > -
> > >  builtin_sources = [
> > > +  hook_list,
> > >    'builtin/add.c',
> > >    'builtin/am.c',
> > >    'builtin/annotate.c',
> >
> > ... that's exactly what you do. So this fix looks good to me, thanks!
> 
> Thank you for the review. This is my first contribution to the Git
> project and I'm trying to follow the lengthy SubmittingPatches guide.

It's gotten quite long by now indeed.

> I believe we have "reached a consensus" and my next steps are as follows:
> 
> - Add Reviewed-by (or Acked-by?) for Patrick and Adrian.
> - Send the patch to Junio with the list CCed.
> 
> Do I have that right?

In the current state you don't have to do anything. Reviews were
favorable and you weren't asked to do any changes, so there is no need
for you to send a second version. Unless somebody else chimes in and
asks for changes, Junio will eventually pick up this patch and may then
add the Reviewed-by trailers himself.

Thanks for your contribution, and welcome to Git :)

Patrick