From: Patrick Steinhardt Date: Tue, 30 Jun 2026 10:31:59 GMT Subject: Re: [PATCH v2 4/5] builtin/refs: add "create" subcommand Message-ID: In-Reply-To: On Mon, Jun 29, 2026 at 01:58:32PM -0700, Junio C Hamano wrote: > Patrick Steinhardt writes: > > > + if (repo_get_oid_with_flags(repo, argv[1], &newoid, GET_OID_SKIP_AMBIGUITY_CHECK)) > > + die(_("invalid object ID: '%s'"), argv[1]); > > + if (is_null_oid(&newoid)) > > + die(_("cannot create reference with null old object ID")); > > An apparent typo here, "with null old" -> "with null new object > name". > > Other than that, I think this one is good. Yes, indeed, good eyes. Patrick