From: Justin Tobler Date: Mon, 29 Jun 2026 18:11:53 GMT Subject: Re: [PATCH 1/6] object-file: rename files transaction prepare function Message-ID: In-Reply-To: On 26/06/24 11:26AM, Junio C Hamano wrote: > Justin Tobler writes: > > > The "files" ODB transaction backend lazily creates a temporary object > > directory when the first loose object is written to the transaction via > > `prepare_loose_object_transaction()`. In a subsequent commit, the > > temporary directory is used to also write packfiles to. > > > > Rename the function to `odb_transaction_files_prepare()` accordingly. > > Taken by itself this renaming does make sense, but there are many > other function that follow the historical naming convention, like > {fsync,flush}_loose_object_transaction(). Should we rename them for > consistency with the new naming scheme, not necessarily as part of > this series but with a todo comment to do so once the dust settles, > or something? Ya, both {fsync,flush}_loose_object_transaction() are probably good candidates to be renamed to odb_transaction_files_{flush,flush} also. In the next version, I'll probably add another patch to do so accordingly. -Justin