From: Patrick Steinhardt Date: Wed, 08 Jul 2026 06:41:24 GMT Subject: Re: [PATCH v2 03/11] object-file: embed transaction flush logic in commit function Message-ID: In-Reply-To: <20260708041412.1157499-4-jltobler@gmail.com> On Tue, Jul 07, 2026 at 11:14:04PM -0500, Justin Tobler wrote: > When a "files" transaction is committed, > `flush_loose_object_transaction()` is invoked to handle performing a > hardware flush along with migrating the temporary object directory into > the primary. In a subsequent commit, the temporary directory is also > used to write packfiles. > > Instead of maintaining a separate helper function, embed the logic to > flush and migrate the temporary directory directly into > `odb_transaction_files_commit()`. The change itself looks simple enough, but this makes me wonder why we want to change this. Like, what subsequent step does this enable that would otherwise be harder to do? Maybe this will be answered by a subsequent commit. Patrick