From: Patrick Steinhardt Date: Thu, 25 Jun 2026 06:35:57 GMT Subject: Re: [PATCH v5 09/11] reftable: split up write options Message-ID: In-Reply-To: On Wed, Jun 24, 2026 at 05:06:32PM -0500, Justin Tobler wrote: > On 26/06/22 10:28AM, Patrick Steinhardt wrote: > > When initializing the reftable stack the caller may optionally pass some > > write options. These write options mix up two different concerns though: > > > > - Of course, they allow the caller to configure how new reftables are > > being written. > > > > - But they also allow the caller to configure the stack itself, like > > its hash ID and the `on_reload` callback. > > > > This is somewhat awkward, as it doesn't easily give the caller the > > flexibility to for example write multiple reftables with different > > options. Furthermore, this requires us to eagerly parse relevant > > configuration when initializing the reftable backend. > > Naive question: are there any current use cases where callers may want > to write multiple reftables with a different set of options? Can > reftables written with different options pose any correctness issues? There aren't, but in theory it's totally fine to do it. One could for example imagine that a large reference transaction wants to use a larger block size with a different restart interval. The only thing that of course shouldn't happen is that the different tables use different hashes. Patrick