From: Patrick Steinhardt Date: Wed, 24 Jun 2026 11:26:47 GMT Subject: Re: [PATCH 4/6] odb/transaction: propagate commit errors Message-ID: In-Reply-To: <20260624041920.2601961-5-jltobler@gmail.com> On Tue, Jun 23, 2026 at 11:19:18PM -0500, Justin Tobler wrote: > diff --git a/odb/transaction.h b/odb/transaction.h > index cd6d50f2e5..7898770071 100644 > --- a/odb/transaction.h > +++ b/odb/transaction.h > @@ -54,7 +54,7 @@ static inline void odb_transaction_begin_or_die(struct object_database *odb, > * Commits an ODB transaction making the written objects visible. If the > * specified transaction is NULL, the function is a no-op. > */ > -void odb_transaction_commit(struct odb_transaction *transaction); > +int odb_transaction_commit(struct odb_transaction *transaction); Should the function comment be amended, as well? We should definitely point out that calling this with a NULL transaction also returns success. Patrick