From: Taylor Blau Date: Fri, 19 Jun 2026 14:46:57 GMT Subject: Re: [PATCH v2 2/4] pack-objects: support reachability bitmaps with `--path-walk` Message-ID: In-Reply-To: On Fri, Jun 19, 2026 at 10:36:54AM -0400, Derrick Stolee wrote: > On 6/19/2026 10:16 AM, Taylor Blau wrote: > > On Fri, Jun 12, 2026 at 09:03:41AM -0400, Derrick Stolee wrote: > >> On 6/2/2026 6:21 PM, Taylor Blau wrote: > >> > >>> As a result, we can see significantly reduced pack sizes from p5311 > >>> before this commit: > >> > >> I mentioned this before, but the pack _sizes_ aren't changing in this > >> example. We are computing them more quickly, though. > > > > Thanks for pointing this out. The paragraph following the perf output > > below correctly explains the results ("We get the same size of output > > pack, but [...]"), but this one is obviously wrong. > > > >> Since we are testing --path-walk on both sides, the change across this > >> commit is that we are using the bitmaps for the "counting objects" phase > >> and then potentially using the --path-walk algorithm to construct the > >> packfile. > > > > I'm not sure I agree here. Because we are using bitmaps, we're relying > > on pack-reuse to construct the output pack, not --path-walk. I mentioned > > in git-pack-objects(1), but the combination of seeing "--path-walk" and > > "--use-bitmap-index" together only means that we will use a path-walk > > traversal as fallback if we can't get an answer by relying on bitmaps. > > I guess my thought was that we'd construct bitmaps when they are > available, but how do we walk objects to get the objects for commits > that are not represented by bitmaps? Good question, and we use the existing bitmap traversal (or the boundary-based one, if enabled). In that case we really want something that is topological and not path-based, so we can terminate the walk as soon as we run into an existing set bit, or something on the negated side of the query. > But you make a good point: we don't need to do that for functional > use: the bitmap code does an object walk to produce a bitmap, and it's > all in a layer "below" the pack-objects code. > > So essentially, this _isn't_ a combined approach: it's "use bitmaps if > we can, and fall back to --path-walk if we can't" which is changing > from our previous behavior of "--path-walk means we don't try to use > bitmaps". Exactly! Thanks, Taylor