From: Justin Tobler Date: Wed, 17 Jun 2026 18:09:24 GMT Subject: Re: [PATCH v2 6/8] repository: free main reference database Message-ID: In-Reply-To: <20260615-b4-pks-refs-avoid-chdir-notify-reparent-v2-6-f4854aa99859@pks.im> On 26/06/15 03:56PM, Patrick Steinhardt wrote: > While we release worktree and submodule reference databases when > clearing a repository, we don't ever release the main reference > database. This memory leak went unnoticed because its pointer is > kept alive by the "chdir_notify" subsystem. > > Fix the memory leak. > > Signed-off-by: Patrick Steinhardt > --- > repository.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/repository.c b/repository.c > index 187dd471c4..e2b5c6712b 100644 > --- a/repository.c > +++ b/repository.c > @@ -421,6 +421,11 @@ void repo_clear(struct repository *repo) > FREE_AND_NULL(repo->remote_state); > } > > + if (repo->refs_private) { > + ref_store_release(repo->refs_private); > + FREE_AND_NULL(repo->refs_private); > + } Nice fix. :)