From: Taylor Blau Date: Fri, 12 Jun 2026 20:08:04 GMT Subject: Re: [PATCH v4 06/16] midx: support custom `--base` for incremental MIDX writes Message-ID: In-Reply-To: On Fri, Jun 12, 2026 at 02:18:04PM -0400, Taylor Blau wrote: > On Fri, Jun 12, 2026 at 06:21:48AM -0700, Junio C Hamano wrote: > > SZEDER Gábor writes: > > > > >> + layer="$(git multi-pack-index write --bitmap --incremental \ > > >> + --no-write-chain-file --base="$(nth_line 1 "$midx_chain")")" && > > > > > > There is no 'nth_line' helper function in this test script. > > > > Good eyes. It has been there in the file next door t5335 since > > February, but not available here in t5334. > > Good spotting indeed. Fortunately or unfortunately for us, pulling on > this thread revealed a bit of a rabbit hole. Patches forthcoming.. https://lore.kernel.org/git/cover.1781294771.git.me@ttaylorr.com/ Thanks, Taylor