From: Dominik Loidolt <dominik.loidolt@univie.ac.at>
Date: Fri, 12 Jun 2026 19:04:31 GMT
Subject: Re: [PATCH v3 2/2] compat/posix.h: simplify GIT_GNUC_PREREQ() comparison
Message-ID: <aixYPxWiWO9iryKl@eduroam-077-080-003-247.wlan.univie.ac.at>
In-Reply-To: <aiwJSBfRbUFZ70gP@pks.im>

Thanks again for taking the time to review my contribution.

On Fri, Jun 12, 2026 at 03:27:36PM +0200, Patrick Steinhardt wrote:
> > It is also more future-proof, as it no longer assumes that GCC version
> > components stay below 65536.
>
> I feel like all the message needs to say is "let's do it for
> consistency, and it's easier to read". That would've been sufficient,
> whereas this argument here feels a bit thin.

Agreed. I'll simplify the commit message. The "future-proof" bit was a joke I
just couldn't resist, but it may cause more confusion than it is worth.
I'll drop it.

> It would've been nice to either move these changes into a preparatory
> commit or at least mention them

Agreed. I'll split the cleanup into a separate commit.

> I'm not sure myself whether this could use another reroll. It's all just
> nits, and the intent is clear enough.

I think it's worth rerolling.

Thanks,
 Dominik