From: Weijie Yuan Date: Fri, 12 Jun 2026 16:21:04 GMT Subject: Re: [PATCH v2] commit-reach: remove get_reachable_subset() Message-ID: In-Reply-To: On Sat, Jun 13, 2026 at 12:16:34AM +0800, Weijie Yuan wrote: > On Fri, Jun 12, 2026 at 07:41:48AM -0700, Junio C Hamano wrote: > > Weijie Yuan writes: > > > > > On Thu, Jun 11, 2026 at 10:48:18AM -0700, Junio C Hamano wrote: > > >> I wonder if we should talk about it in the SubmittingPatches and/or > > >> MyFirstContribution document? > > > > > > Hi, I think it might be a good idea to cover these details in > > > MyFirstContribution, then cross-reference them from the part of > > > SubmittingPatches that discusses sending a new version. > > > > Sorry to be nitpicky, but the above is omitting too much from your > > quote. "it" in "talk about it" is totally unclear to a reader who > > haven't seen the message you are replying to. > > Oops, so sorry! You are not nitpicky at all, this is totally my > carelessness and fault. Sorry readers! > > Thank you for catching this! It shows that I still need to really > understand the previous patch I wrote, and put it into real practice: > > > It is usually helpful to trim away unrelated context, such as large > > portions of the patch that are not being discussed, while _keeping > > enough quoted text_ for readers to understand *what* you are > > responding to. > > Thank you! I'll immediately set a solid "pre-reply" hook in my .git > folder ;-) Sorry, here I mean setting a pre-reply hook to remind me how to do a good quote when writting a reply mail :-) Sorry for the unnecessary noise, and thank you.