From: Patrick Steinhardt <ps@pks.im>
Date: Wed, 10 Jun 2026 07:03:08 GMT
Subject: Re: [PATCH RFC v2 2/2] builtin/history: abort reword on same message
Message-ID: <aikMLBCC9Rc7q9S7@pks.im>
In-Reply-To: <xmqqbjdj1q1s.fsf@gitster.g>

On Tue, Jun 09, 2026 at 12:17:51PM -0700, Junio C Hamano wrote:
> Pablo Sabater <pabloosabaterr@gmail.com> writes:
> 
> >> > I wonder if we should check that the committer identity is unchanged as
> >> > well in case anyone is using this to fix commits after committing with
> >> > the wrong identity.
> >
> > I think that if you reword a commit committed by someone else but end
> > up with no changes I want it to be kept as it was.
> 
> That depends on the reason why the feature to "reword" the commit is
> being used, and the use case Phillip is talking about is a bit
> different.

So the answer is "it depends". Maybe we should do handle this the same
as git-commit(1) does with its "--reset-author" flag?

Patrick