From: Weijie Yuan Date: Sat, 13 Jun 2026 17:05:04 GMT Subject: Re: [RFC PATCH 2/2] doc: advise batching patch rerolls Message-ID: In-Reply-To: On Sat, Jun 13, 2026 at 09:02:39AM -0700, Junio C Hamano wrote: > Weijie Yuan writes: > > > Contributors often need guidance on how quickly to send later iterations > > of a patch series. Add a rough default of no more than one new version > > of the same series per day so feedback can be batched and reviewers have > > time to comment. > > > > Mention factors that can affect the timing, such as series size, review > > depth, substantial rework, and how close the topic is to being accepted. > > Another good thing to discourage yourself from rerolling too quickly > is that such a practice forces you to think twice and be very > careful before sending patches out. As you have only one chance to > get it right before, say, 24 hours, you'd want to make sure that you > would not distract your reviewers with stupid typoes, off-by-one > errors, and such, and concentrate their reviews more on what matters > more, i.e., the higher level design, choice of algorithms, etc. > > > +This consideration applies not only when going from the initial patch to v2, but > > +also to later iterations of the same series. There is no fixed rule for how long > > +to wait before sending a new version. A useful default is to send at most one > > +new version of the same patch series per day. This gives multiple reviewers time > > +to comment, lets you batch feedback together, and gives you time to think > > +through the comments you received. > > And the 24-hour gives equal chance to comment on your patches to > anybody no matter where they live ;-) Thanks for your comments above! Let me think about how to integrate these contents with the patch. > I see you CC'ed Patrick, and I am sure he'll give us more useful > suggestions than I do here ;-) This is his practical advice, and I just stole Patrick´s wording, to be fair ;-) so of course I should CC him and let him know I am a wording thief :-P, hope it wouldn't disturb him ;-) Thank you very much.