From: Patrick Steinhardt Date: Tue, 02 Jun 2026 12:34:40 GMT Subject: Re: [PATCH 2/2] builtin/init-db: deprecate alias for git-init(1) Message-ID: In-Reply-To: <455fc75a-444f-4760-a22f-54a2ec29618b@app.fastmail.com> On Tue, Jun 02, 2026 at 09:54:02AM +0200, Kristoffer Haugsbakk wrote: > On Tue, Jun 2, 2026, at 08:45, Patrick Steinhardt wrote: > > On Tue, Jun 02, 2026 at 07:22:50AM +0900, Junio C Hamano wrote: > >> "Kristoffer Haugsbakk" writes: > >>>[snip] > >> Or just leave it without deprecation. It does not cost much to keep > >> "init-db", and because we expanded what "git database" means in > >> later versions of Git since its invention, the name still makes > >> sense. Thank Linus for not naming it "init-odb"---that might have > >> been a valid excuse to rename it because it does not cover the ref > >> database and config database and others. > > > > I wouldn't mind that outcome much, either. What triggered this series is > > that I'm always annoyed that it's "builtin/init-db.c" instead of > > "builtin/init.c", and the same for `cmd_init_db()`. But I intentionally > > constructed the series in a way that the first commit can be picked > > as-is, so that we can adjust our code to the modern world while not > > doing the deprecation dance. > > > > So I'd be equally happy if we just drop the second commit in this > > series. > > Could it be worthwhile to mark it as soft deprecated? In the sense that > it is a legacy alias that is not planned for removal? The question is how such a soft deprecation would look like. Would it be a warning, only, but other than that it behaves just as before? Should we mark it as `DEPRECATED` in "git.c"? Both of those? Patrick