From: Patrick Steinhardt Date: Fri, 22 May 2026 06:06:10 GMT Subject: Re: [PATCH 1/8] t0001: plug test gaps for git-init(1) with GIT_OBJECT_DIRECTORY Message-ID: In-Reply-To: <741c2a26-7380-4d8e-aa91-fb237e9f10dc@app.fastmail.com> On Thu, May 21, 2026 at 07:51:59PM +0200, Kristoffer Haugsbakk wrote: > On Thu, May 21, 2026, at 09:42, Patrick Steinhardt wrote: > > In subsequent commits we'll rework how we set up the repository. This is > > a somewhat intricate and thus fragile sequence, there's many things that > > Should this be s/, there/; there/ ? Depends on if this is a list of > three items or if “This is” is a subclause that is supposed to point at > “there's many”. That reads a bit better. > > can go subtly wrong, and there are lots of interesting interactions that > > one can discover. > > > > One such discovered edge case was the interaction between git-init(1) > > and the "GIT_OBJECT_DIRECTORY" enviroment variable. When set, the > > behaviour is that the object directory should be created at the path > > that the variable points to. This behaviour is documented as such in > > its man page: > > > > If the object storage directory is specified via the > > GIT_OBJECT_DIRECTORY environment variable then the sha1 directories > > are created underneath; otherwise, the default $GIT_DIR/objects > > directory is used. > > > > Curiously enough though we don't seem to have any tests that exercise > > this directly, and thus a subsequent commit inadvertently broke this > > expectation. > > Isn’t it more that “the upcoming changes *would have* broken” them if > not for this change? This seems to refer to a an alternative commit > history where this change does not exist? Grammar is hard :) But yeah, this of course refers to an alternative commit history I had at one point in time that did break this. Fixed locally, will wait a bit before sending out the next version. Patrick