From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Wed, 20 Nov 2024 10:42:29 GMT
Subject: Re: [PATCH v2 06/10] refs: skip collision checks in initial transactions
Message-ID: <afed1ddc-90fd-446a-9da0-b8e8f3fbb903@app.fastmail.com>
In-Reply-To: <20241120-pks-refs-optimize-migrations-v2-6-a233374b7452@pks.im>

Hi

On Wed, Nov 20, 2024, at 08:51, Patrick Steinhardt wrote:
> While we generally cannot avoid the first check, the second check is
> superfluous in cases where the transaction is an initial one in an
> otherwise empty ref store. The check results in multiple ref reads as
> well as the creation of a ref iterator for every ref we're checking,
> which adds up quite fast when performing the check for many refs.
>
> Introduce a new flag that allows us to skip this check and wire it up in
> such that the backends pass it when running an initial transaction. This

Missing word? “wire it up in such that”.

Maybe: “wire it up so that”.

> leads to significant speedups when migrating ref storage backends. From
> "files" to "reftable":