From: Taylor Blau Date: Wed, 29 Apr 2026 22:40:42 GMT Subject: Re: [PATCH v2 10/16] repack-midx: extract `repack_fill_midx_stdin_packs()` Message-ID: In-Reply-To: <20260429080821.GA1269182@coredump.intra.peff.net> On Wed, Apr 29, 2026 at 04:08:21AM -0400, Jeff King wrote: > On Tue, Apr 21, 2026 at 04:37:42PM -0400, Taylor Blau wrote: > > > This simplifies `write_midx_included_packs()` and prepares for a > > subsequent commit where the same helper is called with `cmd->out = -1` > > to capture the MIDX's checksum from the command's standard output, > > which is needed when writing MIDX layers with `--checksum-only`. > > This should be --no-write-chain-file now, right? It's not used in the > code here, so it's just a commit message fixup. Yup, good spotting. Fixed. Thanks, Taylor