From: Patrick Steinhardt Date: Fri, 08 May 2026 13:20:25 GMT Subject: Re: [PATCH v2 0/2] maintenance(geometric): avoid deadlocks on Windows 10 Message-ID: In-Reply-To: On Thu, May 07, 2026 at 12:51:11PM +0000, Johannes Schindelin via GitGitGadget wrote: > On Windows, maintenance_task_geometric_repack() opens pack index files via > pack_geometry_init() (which mmap()s the .idx files), then spawns git repack > as a child process without setting child.odb_to_close. The parent's mmap()s > prevent the child from deleting old .idx files. > > On Windows 10 builds before the POSIX delete semantics change (between Build > 17134.1304 and 18363.657, see https://stackoverflow.com/a/60512798), this > results in Unlink of file '.git/objects/pack/pack-.idx' failed. Should > I try again? during fetch-triggered auto-maintenance with the geometric > strategy. > > The fix adds the missing child.odb_to_close = the_repository->objects line, > matching all other maintenance tasks. > > The first commit introduces a GIT_TEST_LEGACY_DELETE environment variable to > simulate legacy (pre-POSIX) delete semantics on modern Windows, so the > regression test can verify the fix even on Windows 11. > > This fixes https://github.com/git-for-windows/git/issues/6210. > > Changes since v1: > > * The code now uses git_env_bool() as appropriate (thanks Patrick!) This version looks good to me, thanks! Patrick