From: Patrick Steinhardt Date: Tue, 21 Apr 2026 05:38:59 GMT Subject: Re: [PATCH v2 0/3] t7004: cleanup and modernize brittle tests Message-ID: In-Reply-To: <20260421053334.5414-1-r.siddharth.shrimali@gmail.com> On Tue, Apr 21, 2026 at 11:03:31AM +0530, Siddharth Shrimali wrote: > This patch series addresses brittle testing patterns in t7004-tag.sh. > > In this second version, the first patch has been updated to follow > Junio's "belt-and-suspenders" suggestion. Instead of simply removing > the tag count check, it now uses 'test_cmp' to verify that the repository > state remains unchanged after failed tag creation attempts. This > maintains verification while removing the reliance on a hardcoded > global tag count. > > Subsequent patches continue to modernize the script by removing > hardcoded global state and replacing subshell patterns that could > otherwise suppress Git exit codes, ensuring that crashes (like > segmentation faults) are properly detected. > > Thanks to Patrick and Junio for the feedback on v1 regarding > state verification. Thanks, this version looks good to me! Patrick