From: Patrick Steinhardt Date: Fri, 10 Apr 2026 04:53:32 GMT Subject: Re: [PATCH v2 16/17] odb/source-inmemory: stub out remaining functions Message-ID: In-Reply-To: On Thu, Apr 09, 2026 at 12:39:00PM -0700, Junio C Hamano wrote: > Patrick Steinhardt writes: > > > Stub out remaining functions that we either don't need or that are > > basically no-ops. > > > > Signed-off-by: Patrick Steinhardt > > --- > > odb/source-inmemory.c | 31 +++++++++++++++++++++++++++++++ > > 1 file changed, 31 insertions(+) > > > > diff --git a/odb/source-inmemory.c b/odb/source-inmemory.c > > index 15a6a5ae64..1140b1b916 100644 > > --- a/odb/source-inmemory.c > > +++ b/odb/source-inmemory.c > > @@ -299,6 +299,32 @@ static int odb_source_inmemory_freshen_object(struct odb_source *source, > > return 0; > > } > > > > +static int odb_source_inmemory_begin_transaction(struct odb_source *source UNUSED, > > + struct odb_transaction **out UNUSED) > > +{ > > + return error("inmemory source does not support transactions"); > > +} > > + > > +static int odb_source_inmemory_read_alternates(struct odb_source *source UNUSED, > > + struct strvec *out UNUSED) > > +{ > > + return 0; > > +} > > + > > +static int odb_source_inmemory_write_alternate(struct odb_source *source UNUSED, > > + const char *alternate UNUSED) > > +{ > > + return error("inmemory source does not support alternates"); > > +} > > OK, 00/17 said it only fixed log message, but the messages or > anything end-user facing should consistently say "in-memory". > > Or, "in-core", if "incore" is chosen as part of identifiers to be > consistent with the rest of the system. Good catch, will fix. Thanks! Patrick