From: Marc Strapetz <marc.strapetz@syntevo.com>
Date: Tue, 20 Mar 2018 10:06:31 GMT
Subject: Re: [PATCH v5 0/3] stash push -u -- <pathspec> fixes
Message-ID: <adf6ff41-cc58-89fd-8703-d620babe0cd7@syntevo.com>
In-Reply-To: <20180319232156.30916-1-t.gummerer@gmail.com>

On 20.03.2018 00:21, Thomas Gummerer wrote:
> Thanks again Marc for all the testing and Junio for fixing up my brown
> paper bag copy-pasto.
> 
> This iteration addresses the breakage Marc noticed with the latest
> version of the patches, adds some more tests, and moves all the new
> tests to t3905 instead of t3903, which I just noticed exists and is a
> much better match for the new tests.
> 
> Patch 1 and 3 are the same as in the previous round, Patch 2 is mostly
> rewritten.  Instead of trying to avoid part of the pipeline we're
> using to get rid of changes, we now are getting rid of the 'git clean'
> call in the pathspec case, and use the existing pipeline to get rid of
> changes in untracked files as well.  I'm not adding an interdiff,
> because Patch 2 is mostly rewritten and the other two are unchanged,
> so it is probably easiest to just review patch 2.

Thanks, Thomas. All of my manual tests have been working fine now.

-Marc