From: Santi Béjar Date: Fri, 08 Jan 2010 22:33:16 GMT Subject: Re: [PATCH 2/3] ident.c: check explicit identity for name and email separately Message-ID: In-Reply-To: <7vbph4eg63.fsf_-_@alter.siamese.dyndns.org> On Fri, Jan 8, 2010 at 5:04 PM, Junio C Hamano wrote: > bb1ae3f (commit: Show committer if automatic, 2008-05-04) added a logic to > check both name and email were given explicitly by the end user, but it > assumed that fmt_ident() is never called before git_default_user_config() > is called, which was fragile.  The former calls setup_ident() and fills > the "default" name and email, so the check in the config parser would have > mistakenly said both are given even if only user.name was provided. > > Make the logic more robust by keeping track of name and email separately. > It's a good improvement, thanks. Acked-by: Santi Béjar Santi