From: Santi Béjar <santi@agolina.net>
Date: Sat, 06 Jun 2009 21:03:47 GMT
Subject: Re: [PATCH 3/3] git-parse-remote: remove unused functions
Message-ID: <adf1fd3d0906061403sd13200co286e986c67135f4b@mail.gmail.com>
In-Reply-To: <7v63f9cd4s.fsf@alter.siamese.dyndns.org>

2009/6/6 Junio C Hamano <gitster@pobox.com>:
> Santi Béjar <santi@agolina.net> writes:
>
>> Signed-off-by: Santi Béjar <santi@agolina.net>
>> ---
>>  .gitignore                         |    1 -
>>  Documentation/git-parse-remote.txt |   50 ---------
>>  git-parse-remote.sh                |  204 ------------------------------------
>>  3 files changed, 0 insertions(+), 255 deletions(-)
>>  delete mode 100644 Documentation/git-parse-remote.txt
>
> I do not understand this patch.
>
> With this patch remove git-parse-remote from .gitignore (as if the entire
> file is going away)

Ops, the .gitignore removal was a mistake.

> and its documentation (again as if the entire file is
> going away), so naturally I would have expected to see removal of the file
> in the patch as well (and that means Makefile needs to be touched), but
> that is not what is happening.

I just wanted to remove the unused functions, and their documentation.
But I was removing the two functions that were documented, so I
removed all the file. Maybe I can just remove their documentation and
leave the rest of the file.

Santi