From: Kristoffer Haugsbakk Date: Fri, 14 Aug 2026 10:54:26 GMT Subject: Re: [PATCH 2/4] format-rev: factor option variables into a struct Message-ID: In-Reply-To: On Thu, Aug 13, 2026, at 20:21, Junio C Hamano wrote: > kristofferhaugsbakk@fastmail.com writes: >> From: Kristoffer Haugsbakk >>[snip] >> - const char *format = NULL; >> + struct format_rev_data data = { >> + NULL, NULL, 0, 0, STRING_LIST_INIT_NODUP >> + }; > > It will make it easier to maintain if you used designated > initializer here, i.e., > > struct format_rev_data data = { > .notes = STRING_LIST_INIT_NODUP, > }; > That is excellent. Thanks! >[snip]